Re: [ppc patch] heap memory allocation

[Marco Gerards]

Hollis Blanchard <address@hidden> writes:

> Ok, this is much simpler than the last patch; it just changes which
> hardcoded region of memory we use. These are the areas I think we
> need to watch out for (from memory, so not authoritative):
>
> 0-16 KB     exception handlers
> 4-5 MB      Old World Mac firmware
> 8-? MB      some older RS/6000
> 12-20 MB    newer RS/6000 / pSeries
> 20+-32 MB   other bits on pSeries, like NVRAM
>
> Our link base was chosen at 2MB, which is working fine. This patch uses
> all the memory from the exception handlers (which may or may not be
> claimed by firmware) to the link base. That should give us plenty of
> room for the GRUB heap, while also leaving as much as possible open for
> the OSs to be loaded at.

This is better then what is done now.

>     * kern/powerpc/ieee1275/init.c (grub_machine_init): Call
>     grub_console_init first.
>     Change the memory range used for grub_ieee1275_claim and
>     grub_mm_init_region.
>     Print an error message if the claim fails.

You forgot to mention that grub/misc.h is included.  Can you add
"Include <grub/misc.h>." here?

If you make the change that Johan mentioned, it can go in as far as I
am concerned.

Thanks,
Marco