Re: [patch] Dynamic Loader Bugs

[Marco Gerards]

Timothy Baldwin <address@hidden> writes:

> 1. Gcc 3.4 will delete the module initialization and finalisation functions 
> as 
> they appear to be unused.

Why do you use the used attribute here?  Isn't that what is default?

> 2. grub_dl_load_file contains a null pointer dereference.

Right.  I have seen this bug too.

> 3. The modules contain common symbols, which the dynamic loader can't handle.

What does this mean?  Can you give an example about this.

> 4. The dynamic loader uses the size of common symbols as their address, 
> instead of returning an error.
>
> Attached is a patch which fixes points 1 to 3.

This patch fixes 2 as well, right?

Can you fix bug #4 as well?

I hope someone else with more knowledge about modules can reply as
well.  The patch seems ok to me at first sight, but I am not too sure.

Can you please use "diff -up" next time when making a patch?  That
makes it easier to read.

Thanks,
Marco