Re: grub2 ChangeLog term/i386/pc/serial.c

[Robert Millan]

On Tue, Nov 06, 2007 at 11:33:44PM +0200, Vesa Jääskeläinen wrote:
> >     2007-11-06  Robert Millan  <address@hidden>
> >     
> >             * term/i386/pc/serial.c (serial_hw_put): Switch order of 
> > arguments
> >             in grub_outb() calls.
> >             (serial_hw_init): Likewise.
> > 
> > CVSWeb URLs:
> > http://cvs.savannah.gnu.org/viewcvs/grub2/ChangeLog?cvsroot=grub&r1=1.437&r2=1.438
> > http://cvs.savannah.gnu.org/viewcvs/grub2/term/i386/pc/serial.c?cvsroot=grub&r1=1.4&r2=1.5
> 
> Why on earth those parameters are reversed anyway :) ?

My fault :-)

When I replaced inb() and outb() in that file, I assumed they would have
the same semantics as grub_inb() and grub_outb().

> On all systems that I can remember arguments for lots of things go like
> this:
> 
> func(destination, source)
> 
> examples are:
> memcpy, strcpy
> 
> On most of the other systems outp is also outp(port, value)
> ("destination, source"). Eg. following the same convention.

grub_inb() and grub_outb() are based on the inb()/outb() implementation
from glibc headers, so I kept the same arguments for consistency.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)