Re: [PATCH 1/7] Make boot/i386/pc/boot.S safer to modify

[Robert Millan]

On Tue, Jul 14, 2009 at 09:00:17PM -0400, Pavel Roskin wrote:
> ChangeLog:
> 
>       * include/grub/i386/pc/boot.h: Sort all offsets.
>       (GRUB_BOOT_MACHINE_KERNEL_ADDRESS): Remove, it's unused.
>       (GRUB_BOOT_MACHINE_KERNEL_SEGMENT): Likewise.
>       * boot/i386/pc/boot.S: Assert location of every offset listed in
>       include/grub/i386/pc/boot.h.
> ---
>  boot/i386/pc/boot.S         |    8 +++++++-
>  include/grub/i386/pc/boot.h |   10 ++--------
>  2 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/boot/i386/pc/boot.S b/boot/i386/pc/boot.S
> index 8d8c27c..fb90947 100644
> --- a/boot/i386/pc/boot.S
> +++ b/boot/i386/pc/boot.S
> @@ -65,6 +65,7 @@ start:
>        * this area.
>        */
>  
> +     . = _start + GRUB_BOOT_MACHINE_BPB_START
>       . = _start + 4

Why is this +4 still needed?  If it's alignment, I'd make it explicit.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."