Re: [PATCH v2 0/9] Add UEFI HTTP Boot support for IPv4 and IPv6

[Michael Chang]

On Thu, Jul 06, 2017 at 06:52:02AM +0000, Lin, Keng-Yu wrote:
> > Hi Keng-Yu,
> >
> > Sorry for late reply but I clearing my backlog after long vacation.
> >
> >
> > Thank you for doing the work. Unfortunately it is too late to put it into 
> > 2.02 release (I hope it will happen at the end of February or at beginning 
> > of March). I am adding this patch set to review > after release.
> > Please be patient.
> >
> > Daniel
> 
> Hi Daniel:
>   Wonder if there is any chance to get this patchset moving on.
>   This patchset was well tested on both Qemu/EDK2 and some real HPE ProLiant 
> Gen10 machines.
>   (check the cover letter for more details.)

How many test case did you perform on this patch. More specifically, did you
verify how does it work with existing network commands

 https://www.gnu.org/software/grub/manual/grub.html#Networking-commands

And also environment variables related to network

  https://www.gnu.org/software/grub/manual/grub.html#Network

I think the patch is good at running grub booted directly by UEFI http load
file protocol, assuming the UEFI Handle has configured network protocol down
the road before handing over to grub. But that may not satisfied the user as
they get used to have more than that already.
 
Practically grub can work out more (sophisticated) scenario by exercising the
network commands to configure the network interface one way or the other, and
obviously the patch did not route the same commands to UEFI network stack,
which is regarded as functional regression as it did not apply on UEFI
protocol.

Thanks,
Michael

>       
>   Let me know if there is anything further I can help. :-)
> 
>   Thanks,
> -kengyu
> 
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel