Re: [PATCH v2 0/9] Add UEFI HTTP Boot support for IPv4 and IPv6

[Michael Chang]

On Tue, Jul 11, 2017 at 07:39:16AM +0000, Lin, Keng-Yu wrote:
> > How many test case did you perform on this patch. More specifically, did you
> > verify how does it work with existing network commands
> > 
> >  https://www.gnu.org/software/grub/manual/grub.html#Networking-
> > commands
> > 
> > And also environment variables related to network
> > 
> >   https://www.gnu.org/software/grub/manual/grub.html#Network
> > 
> > I think the patch is good at running grub booted directly by UEFI http load 
> > file
> > protocol, assuming the UEFI Handle has configured network protocol down
> > the road before handing over to grub. But that may not satisfied the user as
> > they get used to have more than that already.
> > 
> > Practically grub can work out more (sophisticated) scenario by exercising 
> > the
> > network commands to configure the network interface one way or the other,
> > and obviously the patch did not route the same commands to UEFI network
> > stack, which is regarded as functional regression as it did not apply on 
> > UEFI
> > protocol.
> 
> Hi Michael:
>   Thanks for the comments. 
>   Are you saying that for this patchset, the following environment variables 
> should be supported in the UEFI HTTP Boot mode too?

Yes. And it should not be limited to http but also PXE mode of the UEFI.
Afterall, the UEFI should be acting like alternative module of networking at
user's disposal and should not notice any difference.

Thanks,
Michael

> 
>   * 'net_<interface>_ip'
>   *'net_<interface>_mac'
>   * 'net_<interface>_hostname'
>   * 'net_<interface>_domain'
>   * 'net_<interface>_rootpath'
>   * 'net_<interface>_extensionspath'
>   * 'net_<interface>_boot_file'
>   * 'net_<interface>_dhcp_server_name'
>   * 'net_<interface>_next_server'
>   * 'net_default_interface'
>   * 'net_default_ip'
>   * 'net_default_mac'
>   * 'net_default_server'
> 
>   And the following commands:
> 
> * net_add_addr:    Add a network address  
> * net_add_dns:    Add a DNS server  
> * net_add_route:    Add routing entry  
> * net_bootp:    Perform a bootp autoconfiguration  
> * net_del_addr:    Remove IP address from interface  
> * net_del_dns:    Remove a DNS server  
> * net_del_route:    Remove a route entry  
> * net_get_dhcp_option:    Retrieve DHCP options  
> * net_ipv6_autoconf:    Perform IPv6 autoconfiguration  
> * net_ls_addr:    List interfaces  
> * net_ls_cards:    List network cards  
> * net_ls_dns:    List DNS servers  
> * net_ls_routes:    List routing entries  
> * net_nslookup:    Perform a DNS lookup  
> 
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel