[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] cmdline: pass kernel command line as verbatim
From: |
Michael Chang |
Subject: |
Re: [PATCH] cmdline: pass kernel command line as verbatim |
Date: |
Mon, 6 Apr 2020 16:55:52 +0800 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Mon, Apr 06, 2020 at 09:18:26AM +0200, Olaf Hering wrote:
> Am Sat, 4 Apr 2020 13:31:40 +0800
> schrieb Michael Chang <address@hidden>:
>
> > 7 files changed, 229 insertions(+), 2 deletions(-)
>
> A lot of churn. It is called 'verbatim', yet it inserts extra characters in
> the output buffer.
What verbatim means when people read that from the manual is really not
up to me. Here my attempt was merely to fix problem as you did but
mostly reflecting my own point of view. Afterall the table provided in
the description can easily be used as reason to turn down the patch if
it really not making sense on the premise that we have agreed on a real
fix would be looking like, be it yours, mine or anyone else's proposal.
> I'm still stunned why there is an argument about the obvious bugfix.
It is absolutely bugfix, however any prospective impact on grub.cfg that
a bugfix would introduce is always a thing for upstream to adopt it.
Thanks,
Michael
> Good luck.
>
> Olaf