[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/10] module-verifier: make it possible to run checkers on g
From: |
Javier Martinez Canillas |
Subject: |
Re: [PATCH 10/10] module-verifier: make it possible to run checkers on grub-module-verifierxx.c |
Date: |
Mon, 6 Apr 2020 11:51:18 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
Hello Daniel,
On 4/3/20 9:29 PM, Daniel Kiper wrote:
> On Fri, Mar 13, 2020 at 08:17:17PM +0100, Javier Martinez Canillas wrote:
>> From: Peter Jones <address@hidden>
>>
>> This makes it so you can treat grub-module-verifierxx.c as a file you can
>> build directly, so syntax checkers like vim's "syntastic" plugin, which uses
>> "gcc -x c -fsyntax-only" to build it, will work.
>>
>> One still has to do whatever setup is required to make it pick the right
>> include dirs, which -W options we use, etc., but this makes it so you can do
>> the checking on the file you're editing, rather than on a different file.
>>
>> Signed-off-by: Peter Jones <address@hidden>
>> Signed-off-by: Javier Martinez Canillas <address@hidden>
>>
>> ---
>>
>> util/grub-module-verifier32.c | 2 ++
>> util/grub-module-verifier64.c | 2 ++
>> util/grub-module-verifierXX.c | 9 +++++++++
>> 3 files changed, 13 insertions(+)
>
> Comments for this patch are here:
> https://lists.gnu.org/archive/html/grub-devel/2018-09/msg00006.html
>
I missed that this patch was posted before by Peter, sorry. I'll address these
before sending a v2.
> Daniel
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
Best regards,
--
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat