Re: [PATCH 00/10] Another set of patches from Fedora

[Javier Martinez Canillas]

On 4/3/20 9:34 PM, Daniel Kiper wrote:
> On Fri, Mar 13, 2020 at 08:06:32PM +0100, Javier Martinez Canillas wrote:
>> Hello,
>>
>> This is another set of somewhat small patches that we have been carrying in 
>> the
>> Fedora package. I found that some of them have already been posted to the 
>> list,
>> so for those patches I tried to address the issues pointed out in that 
>> version.
>>
>> I'm including all patches in the same set because I think that will make 
>> review
>> easier but I can split in smaller patch series if that is preferred.
>>
>> Best regards,
>> Javier
>>
>>
>> Hans de Goede (5):
>>   efi/console: Do not set text-mode until we actually need it
>>   efi/console: Add grub_console_read_key_stroke() helper function
>>   efi/console: Implement getkeystatus() support
>>   kern/term: Make grub_getkeystatus helper funtion available everywhere
>>   kern/term: Accept ESC, F4 and holding SHIFT as user interrupt keys
>>
>> Javier Martinez Canillas (1):
>>   efi/console: Move grub_console_set{colorstate,cursor} higher in the
>>     file
> 
> I think these patches should form one patchset.
>

Thanks a lot for your feedback and comments. I'll split this and also make sure
to update the docs besides addressing the issues you pointed out.
 
>> Peter Jones (3):
>>   i386: Make pmtimer tsc calibration not take 51 seconds to fail
>>   kern: Make it possible to subtract conditions from debug=
>>   module-verifier: make it possible to run checkers on
>>     grub-module-verifierxx.c
>>
>> Steve Langasek (1):
>>   templates: Output a menu entry for firmware setup on UEFI FastBoot
>>     systems
> 
> These should be posted separately, not in patchset...
>

Ok.
 
> Please take into account my comments and repost the patches. I am still
> considering all of them as 2.06 material.
>

Great, thanks again.
 
> Daniel
> 

Best regards,
-- 
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat