grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix typo


From: Ave Milia
Subject: Re: [PATCH] Fix typo
Date: Tue, 18 Aug 2020 15:04:32 +0000

On Monday, August 17, 2020 4:20 PM, Daniel Kiper <dkiper@net-space.pl> wrote:

> On Mon, Aug 03, 2020 at 09:22:49PM +0000, Ave Milia via Grub-devel wrote:
>
> > grub-core/video/bochs.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > diff --git a/grub-core/video/bochs.c b/grub-core/video/bochs.c
> > index 3bcfa53a9..7a249eb21 100644
> > --- a/grub-core/video/bochs.c
> > +++ b/grub-core/video/bochs.c
> > @@ -274,7 +274,7 @@ grub_video_bochs_setup (unsigned int width, unsigned 
> > int height,
> > " supported by bochs video");
> > if (depth == 4)
> >
> > -   return grub_error (GRUB_ERR_NOT_IMPLEMENTED_YET, "4-bpp isn't 
> > cupported");
> >
> > -   return grub_error (GRUB_ERR_NOT_IMPLEMENTED_YET, "4-bpp isn't 
> > supported");
> >
> > bytes_per_pixel = (depth + 7) / 8;
> > if (depth == 4)
>
> May I add "Signed-off-by: Ave Miliaavemilia@protonmail.com" to this patch?

Sure. I thought the change is too insignificant for this.

>
> If yes then: Reviewed-by: Daniel Kiperdaniel.kiper@oracle.com
>
> Daniel
>
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel





reply via email to

[Prev in Thread] Current Thread [Next in Thread]