Re: Generation 0

[Ludovic Courtès]

Nikita Karetnikov <address@hidden> skribis:

> What about these patches?  Should the first patch also test the
> following case?
>
> +                (let ((numbers (generation-numbers profile)))
> +                  (if (equal? numbers '(0))
> +                      (exit 1)
> +                      (for-each list-generation numbers))))

The first patch below already contains that snippet, so I’m not sure
what you mean.

> From f42056aa768a405a893b5846dad8f8fa576b1156 Mon Sep 17 00:00:00 2001
> From: Nikita Karetnikov <address@hidden>
> Date: Tue, 24 Sep 2013 22:11:16 +0000
> Subject: [PATCH 1/2] guix package: Exit with 1 when a generation cannot be
>  listed.
>
> * guix/scripts/package.scm (guix-package)[process-query]: Exit with 1
>   when a generation does not exist or the profile points to the zeroth
>   generation.
> * tests/guix-package.sh: Test the former case.

OK, please push.

> From bea0168c28932921e6e2d6dcf3e9a26c555b698c Mon Sep 17 00:00:00 2001
> From: Nikita Karetnikov <address@hidden>
> Date: Tue, 24 Sep 2013 22:18:09 +0000
> Subject: [PATCH 2/2] guix package: Do not list the zeroth generation.
>
> * guix/scripts/package.scm (guix-package)[process-query]: Change
>   'list-generation' to not list the zeroth generation.
> * tests/guix-package.sh: Test it.
> * doc/guix.texi (Invoking guix package): Document it, and use the
>   right term when talking about generations.

OK, push as well.

Thanks,
Ludo’.