Re: [PATCH] guix package: Add '--delete-generations'.

[Ludovic Courtès]

Nikita Karetnikov <address@hidden> skribis:

>>>>> I had noticed that ‘--roll-back’ doesn’t output anything with
>>>>> ‘--dry-run’, so I implemented ‘--delete-generations’ similarly.  Maybe
>>>>> it would be better to print something.  WDYT?
>
>>>> Agreed (in a separate patch.)
>
> I don’t think that I’ll have time for this before the release.  I’d
> like to be able to test the MIPS binaries.

OK, no problem.

>>>> “Delete the generations matching @var{patterns} or ... when omitted.”
>
>>>> Or what actually?  I would expect it to delete all the generations but
>>>> the current one when PATTERN is omitted, right?
>
> OK.  Should it delete the current generation when it’s specified
> explicitly, e.g., ‘--delete-generations=5’?  

Yes.

> What about other patterns?

It should do what the pattern says, including removing the current
generation.

My only concern was about the behavior of ‘--delete-generations’ without
any pattern, which should not remove the current generation IMO.

>>>>> +(define (link-to-empty-environment generation)
>>>>> +  "Link GENERATION, a string, to the empty environment."
>
>>>> s/environment/profile/ maybe?  (I know there are other inconsistencies
>>>> in these files.)
>
> OK.
>
>>>> Ideally this factorization would go in a patch of its own, before the
>>>> one that adds --delete-generations.  Is that doable for you?
>
>>> I think so.
>
> Sorry, I’m not sure what have to be changed.  (I’ve just looked
> through the module.)  Do you have time to work on this?

Nothing has to be changed; it’s just that I’d prefer to put the bits
that introduce ‘link-to-empty-environment’ in a separate patch, for
clarity.

I could do it, but it may be easier for you to do it, no?

Thanks,
Ludo’.