Re: [PATCH] guix package: Add '--delete-generations'.

[Ludovic Courtès]

Nikita Karetnikov <address@hidden> skribis:

>> Frankly, I don’t like it.  I think the default behavior should not be to
>> let the user shoot themself in the foot.
>
>> WDYT?
>
> OK, what about these patches?  Can I push them?
>
>
> From 86d29a8b233d5cf6549fbcddf43b185086b7d178 Mon Sep 17 00:00:00 2001
> From: Nikita Karetnikov <address@hidden>
> Date: Wed, 25 Sep 2013 03:34:49 +0000
> Subject: [PATCH 2/3] guix package: Add 'link-to-empty-profile'.
>
> * guix/scripts/package.scm (link-to-empty-profile): New function.
>   (roll-back): Use it.

OK, please push.

> From c246f4a72ade85dffa95d7c598e24539896ca5a5 Mon Sep 17 00:00:00 2001
> From: Nikita Karetnikov <address@hidden>
> Date: Thu, 26 Sep 2013 02:36:24 +0000
> Subject: [PATCH 3/3] guix package: Add '--delete-generations'.
>
> * guix/scripts/package.scm (switch-to-previous-generation): New function.

(Normally that part would go in a patch of its own since it’s
refactoring unrelated to the implementation of ‘--delete-generations’,
but that’s OK for this time.)

>   (roll-back): Use the new function instead of 'switch-link'.
>   (show-help): Add '--delete-generations'.
>   (%options): Likewise.
>   (guix-package)[process-actions]: Add 'current-generation-number',
>   'display-and-delete', and 'delete-generation'.  Add support for
>   '--delete-generations', and reindent the code.
> * tests/guix-package.sh: Test '--delete-generations'.
> * doc/guix.texi (Invoking guix-package): Document '--delete-generations'.

Looks good to me, please push!

Thanks for all the work!

Ludo’.