Re: [PATCH 0/2] Add libpeas.

[Ludovic Courtès]

Cyril Roelandt <address@hidden> skribis:

> These two patches add libpeas. The first one enables the introspection feature
> for a few GNOME packages; the second adds libpeas.

Nice!

> +           ;; The scanner will use the CC environment variable.
> +           (setenv "CC" "gcc")

Before we copy/paste these two lines in a dozen packages ;-), what about
patching the damn scanner directly in gobject-introspection?

IIUC it’d be just about patching ‘giscanner/sourcescanner.py’ to default
to /nix/store/.../bin/gcc instead of cc.

WDYT?

> +    (description
> +     "libpeas is a gobject-based plugins engine, and is targetted at giving
> +every application the chance to assume its own extensibility. It also has a 
> set
> +of features including, but not limited to:
> +
> +-  multiple extension points
> +-  on demand (lazy) programming language support for C, Python and JS
> +- simplicity of the API")

I think we should avoid item lists in descriptions, because we don’t
parse them as such currently.  Also, two-spaces-after-period please.

Other than that, that looks all good to me, thanks!

Ludo’.