Re: [PATCH 0/2] Add libpeas.

[Cyril Roelandt]

On Tue, Oct 15, 2013 at 10:12:25PM +0200, Ludovic Courtès wrote:
> Cyril Roelandt <address@hidden> skribis:
> 
> > These two patches add libpeas. The first one enables the introspection 
> > feature
> > for a few GNOME packages; the second adds libpeas.
> 
> Nice!
> 
> > +           ;; The scanner will use the CC environment variable.
> > +           (setenv "CC" "gcc")
> 
> Before we copy/paste these two lines in a dozen packages ;-), what about
> patching the damn scanner directly in gobject-introspection?

Indeed, this makes sense :)

> 
> IIUC it’d be just about patching ‘giscanner/sourcescanner.py’ to default
> to /nix/store/.../bin/gcc instead of cc.
> 
> WDYT?

I patched it so that it first tries to use $CC, then 'cc', then
/nix/store/.../bin/gcc. This way, if the user set $CC or has a 'cc' symlink,
there will be no surprises.

> 
> > +    (description
> > +     "libpeas is a gobject-based plugins engine, and is targetted at giving
> > +every application the chance to assume its own extensibility. It also has 
> > a set
> > +of features including, but not limited to:
> > +
> > +-  multiple extension points
> > +-  on demand (lazy) programming language support for C, Python and JS
> > +- simplicity of the API")
> 
> I think we should avoid item lists in descriptions, because we don’t
> parse them as such currently.  Also, two-spaces-after-period please.

OK.

> 
> Other than that, that looks all good to me, thanks!
> 

I'll resubmit these two patches as part of a larger patch series that adds eog
(Eye of GNOME) and its dependencies.

Cyril.