Re: [PATCH] gnu: Add SDL extension libraries

[Ludovic Courtès]

"Thompson, David" <address@hidden> skribis:

> On Thu, Nov 21, 2013 at 7:23 AM, Ludovic Courtès <address@hidden> wrote:
>> Is the copyright/licensing of these packages clear?  In particular, do
>> all the files within each package have clearly the same license, or a
>> compatible license?  (I’d expect it to be the case given that SDL is
>> widespread, but just asking to be sure.)
>
> I will go through the source code and double check.

Thanks.  (Another way to get hints is to look at the Trisquel or Debian
patches, or
<http://libreplanet.org/wiki/List_of_software_that_does_not_respect_the_Free_System_Distribution_Guidelines>.)

>>> +(define sdl-image
>>> +  (package
>>> +    (name "sdl-image")
>>> +    (version "1.2.12")
>>> +    (source (origin
>>> +             (method url-fetch)
>>> +             (uri
>>> +              (string-append 
>>> "http://www.libsdl.org/projects/SDL_image/release/SDL_image-";
>>> +                             version ".tar.gz"))
>>> +             (sha256
>>> +              (base32
>>> +               "16an9slbb8ci7d89wakkmyfvp7c0cval8xw4hkg0842nhhlp540b"))))
>>> +    (build-system gnu-build-system)
>>> +    ;; FIXME: Add webp
>>> +    (propagated-inputs `(("sdl" ,sdl)
>>> +                         ("libpng" ,libpng)
>>> +                         ("libjpeg" ,libjpeg)
>>> +                         ("libtiff" ,libtiff)))
>>
>> Are you sure that all these need to be propagated?
>>
>> (An input typically needs to be propagated if an installed header
>> #includes a header of that input, or if the .pc file mentions that input
>> in its ‘Requires:’ field.)
>
> I'm pretty sure that they are runtime dependencies, but I will check
> the .pc file and verify.

I wouldn’t be surprised if sdl-image’s headers #include SDL’s headers;
dunno about the others.

Thanks,
Ludo’.