Re: [PATCH] gnu: Add SDL extension libraries

[David Thompson]

On 11/21/2013 07:23 AM, Ludovic Courtès wrote:
> David Thompson <address@hidden> skribis:
> 
>> Attached is a patch to add the following extension libraries for SDL
>> 1.x: SDL_gfx, SDL_image, SDL_mixer, SDL_net, and SDL_ttf.
> 
> Wow, cool.
> 
> Is the copyright/licensing of these packages clear?  In particular, do
> all the files within each package have clearly the same license, or a
> compatible license?  (I’d expect it to be the case given that SDL is
> widespread, but just asking to be sure.)

Turns out that I was a little sloppy with the licenses. All of these are
zlib licensed, but I had specified bsd-3 for a couple of them.
> 
>> +(define sdl-image
>> +  (package
>> +    (name "sdl-image")
>> +    (version "1.2.12")
>> +    (source (origin
>> +             (method url-fetch)
>> +             (uri
>> +              (string-append 
>> "http://www.libsdl.org/projects/SDL_image/release/SDL_image-";
>> +                             version ".tar.gz"))
>> +             (sha256
>> +              (base32
>> +               "16an9slbb8ci7d89wakkmyfvp7c0cval8xw4hkg0842nhhlp540b"))))
>> +    (build-system gnu-build-system)
>> +    ;; FIXME: Add webp
>> +    (propagated-inputs `(("sdl" ,sdl)
>> +                         ("libpng" ,libpng)
>> +                         ("libjpeg" ,libjpeg)
>> +                         ("libtiff" ,libtiff)))
> 
> Are you sure that all these need to be propagated?
> 
> (An input typically needs to be propagated if an installed header
> #includes a header of that input, or if the .pc file mentions that input
> in its ‘Requires:’ field.)

You were right. No need to propagate anything besides sdl.

> 
> Otherwise looks good to me!
> 
> Thanks,
> Ludo’.
> 

Updated patch attached. If you think it looks good I can push it to master.

- Dave

0001-gnu-Add-SDL-extension-libraries.patch
Description: Text Data