guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu:add SLiM v2


From: Ludovic Courtès
Subject: Re: [PATCH] gnu:add SLiM v2
Date: Mon, 25 Nov 2013 23:00:51 +0100
User-agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3 (gnu/linux)

"Guy Grant" <address@hidden> skribis:

> Second version of the patch to add SLiM, the Desktop/Session Manager.
> As always, any questions or concerns -- feel free to mention them.

I just pushed the patch.

However there were a few things missing: I added a ChangeLog-style
commit log (see ‘HACKING’), removed trailing spaces, went through the
source to check the license (next time please reply to my questions
in-line so we don’t forget anything), and added the file to
gnu-system.am.

Please check the commit to see how this was all done so you’re all set
for next time.  ;-)

> +                   (substitute* "CMakeLists.txt" 
> +                     '(("/etc") 

There was a typo here (there shouldn’t be a quote here.)

Thanks!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]