Re: [PATCH] gnu:add SLiM

[Ludovic Courtès]

"Guy Ze Grant" <address@hidden> skribis:

> Finally, I think I'm finished with SLiM; Thanks again Civodul and anyone
> else who threw their hat in to offer advice. Attatched is the patch -- any
> questions and/or critques of course are welcome. :^)

Nice!

> From ccb1526ab9be70a3157435edc677d926b2bb024e Mon Sep 17 00:00:00 2001
> From: Guy Grant <address@hidden>
> Date: Thu, 21 Nov 2013 20:36:08 -0600
> Subject: [PATCH] Add SLiM to packages
>
> ---
>  gnu/packages/slim.scm | 78 
> +++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 78 insertions(+)
>  create mode 100644 gnu/packages/slim.scm

In the final version, please make sure to include a GNU ChangeLog-style
commit log.

You may want to run ‘git config --global user.email address@hidden also.

> diff --git a/gnu/packages/slim.scm b/gnu/packages/slim.scm
> new file mode 100644
> index 0000000..3cd4a1f
> --- /dev/null
> +++ b/gnu/packages/slim.scm
> @@ -0,0 +1,78 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright \302\251 2013 Guy Grant <address@hidden>

This doesn’t seem to be UTF-8, is it?

> +(define-public slim
> +  (package
> +    (name "slim")
> +    (version "1.3.3") ;; This it the latest on the SF page, the one on the 
> website is 1.3.6 ... but the binary isn't static.

What does “the binary isn’t static” mean?

Also, please wrap lines at 80 chars.

> +    (arguments '(#:phases (alist-cons-before
> +                           'configure 'set-etc-and-lib-location
> +                           (lambda _ (substitute* "CMakeLists.txt" 

Skip a line after ‘_’, and...

> +                                        (("/etc") (string-append

... after ("etc").

(See the other files for example, and “Coding Style” in HACKING.)

> +                          #:configure-flags '("-DUSE_PAM=yes" 
> "-DUSE_CONSOLEKIT=no")
> +                          #:tests? #f))                                      
>                         

Should be aligned with #:phases.

> +    (license l:gpl2)))

Can you confirm that it’s GPLv2-only, and that all the files appear to
be under that license or a compatible one?

With those details fixed, it’s ready for inclusion.

Thanks!

Ludo’.