Re: [PATCH] gnu: Add freeimage.

[Andreas Enge]

Hello!

On Sat, Nov 01, 2014 at 11:48:46AM -0400, David Thompson wrote:
> +            (uri (string-append 
> "mirror://sourceforge/freeimage/Source%20Distribution/"
> +                                version "/FreeImage"
> +                                (string-join (string-split version #\.) "")
> +                                ".zip"))

This looks a bit longer than the 80 characters limit.

> +                'unpack
> +                (lambda* (#:key source #:allow-other-keys)
> +                  (and (zero? (system* "unzip" source))
> +                       (chdir "FreeImage")))

I wonder if this should not be moved to the standard unpack phase. Can we
determine the file format and use the appropriate tool, unzip or tar,
automatically? (Assuming that there are no .tar.zip out there, of course.)

Andreas