guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add freeimage.


From: David Thompson
Subject: Re: [PATCH] gnu: Add freeimage.
Date: Sun, 02 Nov 2014 12:55:01 -0500
User-agent: Notmuch/0.18.1 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu)

Andreas Enge <address@hidden> writes:

> On Sat, Nov 01, 2014 at 01:21:55PM -0400, David Thompson wrote:
>> +    '(#:phases (alist-replace
>> +                'unpack
>> +                (lambda* (#:key source #:allow-other-keys)
>> +                  (and (zero? (system* "unzip" source))
>> +                       (chdir "FreeImage")))
>> +                (alist-delete
>> +                 'configure
>> +                 (alist-cons-before
>> +                  'build 'patch-makefile
>> +                  (lambda* (#:key outputs #:allow-other-keys)
>> +                    (substitute* "Makefile.gnu"
>> +                      (("/usr") (assoc-ref outputs "out"))
>> +                      (("-o root -g root") "")))
>> +                  %standard-phases)))
>
> I think that instead of adding patch-makefile before build, I would let it
> replace configure. But this is just a matter of taste, so please do as you
> please.

That's a fair point, though I have already pushed.  Thanks, anyhow. :)

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate



reply via email to

[Prev in Thread] Current Thread [Next in Thread]