Re: [PATCH 4/4] gnu: matplotlib: Add gtk3 backends.

[Federico Beffa]

On Mon, Dec 15, 2014 at 11:37 PM, Ludovic Courtès <address@hidden> wrote:
> One should get a message about GI_TYPELIB_PATH, but only if
> gobject-introspection is also installed.  Not sure if that helps.

My question was actually how to produce the message. Is that
automatically handled by the 'search-path' directive in the package?
If not, could you point me an example?

>> From e1e3df22ea06bd7325bc2a1fd389c89f13ccf752 Mon Sep 17 00:00:00 2001
>> From: Federico Beffa <address@hidden>
>> Date: Thu, 11 Dec 2014 14:26:13 +0100
>> Subject: [PATCH 4/4] gnu: matplotlib: Add gtk3 backends.
>>
>> * gnu/packages/python.scm (python-matplotlib, python2-matplotlib): Add
>>   necessary inputs and 'configure-environment' phase.
>
> The patch also move python-pyparsing from ‘inputs’ to
> ‘propagated-inputs’, so it would be good to mention it.

Yes, I forgot to mention this. I've expanded the commit log.

>
>> +    (propagated-inputs
>> +     `(("python-pyparsing" ,python-pyparsing)
>> +       ("python-pygobject" ,python-pygobject)
>
> Could you add a comment saying why they’re here?

Hope my comment is enough :-)

>
>>      (native-inputs
>>       `(("pkg-config" ,pkg-config)
>>         ("texlive" ,texlive)
>> +       ("ghostscript" ,ghostscript)
>
> This doesn’t sound GTK-related, no?

This is an optional dependency and I initially thought to add it to
make the package more "complete". After your comment I decided to look
after what it is actually used for. I learned that it is "only" needed
as one component necessary to make matplotlib able to render text
through LaTeX. So, if we do not make texlive a propagated-input of
matplotlib, then ghostscript is not really needed and I've removed it
again.

Given the size of texlive I'm hesitant in making it a
propagated-input. However, it would make it possible to produce
pictures with the same fonts as the ones used in a latex document,
which is quite nice.

What do you think?

I've removed ghostscript, but I've added another optional dependency:
pillow. This time I mention it in the commit log :-)

Regards,
Fede

0004-gnu-matplotlib-Add-gtk3-backends-and-optional-depend.patch
Description: Text Data