Re: [PATCH 4/4] gnu: matplotlib: Add gtk3 backends.

[Ludovic Courtès]

Federico Beffa <address@hidden> skribis:

> On Mon, Dec 15, 2014 at 11:37 PM, Ludovic Courtès <address@hidden> wrote:
>> One should get a message about GI_TYPELIB_PATH, but only if
>> gobject-introspection is also installed.  Not sure if that helps.
>
> My question was actually how to produce the message. Is that
> automatically handled by the 'search-path' directive in the package?

Yes, exactly.

As an example, if you install both Guile and Guile-JSON, ‘guix package’
will invite you to define GUILE_LOAD_PATH if it’s not already defined.
And then, ‘guix package --search-paths’ will display all the environment
variables that should be defined.

>>> +    (propagated-inputs
>>> +     `(("python-pyparsing" ,python-pyparsing)
>>> +       ("python-pygobject" ,python-pygobject)
>>
>> Could you add a comment saying why they’re here?
>
> Hope my comment is enough :-)

It’s perfect!

>>
>>>      (native-inputs
>>>       `(("pkg-config" ,pkg-config)
>>>         ("texlive" ,texlive)
>>> +       ("ghostscript" ,ghostscript)
>>
>> This doesn’t sound GTK-related, no?
>
> This is an optional dependency and I initially thought to add it to
> make the package more "complete". After your comment I decided to look
> after what it is actually used for. I learned that it is "only" needed
> as one component necessary to make matplotlib able to render text
> through LaTeX. So, if we do not make texlive a propagated-input of
> matplotlib, then ghostscript is not really needed and I've removed it
> again.
>
> Given the size of texlive I'm hesitant in making it a
> propagated-input. However, it would make it possible to produce
> pictures with the same fonts as the ones used in a latex document,
> which is quite nice.
>
> What do you think?

I think TeXLive shouldn’t be a propagated input, nor even something
referenced by the package output.

Perhaps the LaTeX functionality magically becomes available when
‘pdflatex’ or similar is found in $PATH, in which case there’s nothing
to do: users who care would explicitly install TeX Live in their profile
and get that functionality.

WDYT?

> From 4eb7c8dff92f641391c0d902e1ab43536ce0d763 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <address@hidden>
> Date: Thu, 11 Dec 2014 14:26:13 +0100
> Subject: [PATCH 4/4] gnu: matplotlib: Add gtk3 backends and optional
>  dependency.  Adjust inputs.
>
> * gnu/packages/python.scm (python-matplotlib, python2-matplotlib): Add gtk3
>   backends with the necessary inputs and a 'configure-environment' phase.  Add
>   the optional 'python-pillow' dependency.  Move 'python-pyparsing' from
>   'inputs' to 'propagated-inputs' as it is required at run time.

LGTM, thanks!

Ludo’.