Re: [PATCH 1/4] guix: build/glib-or-gtk-build-system: Add support for GIO and XDG theming.

[Ludovic Courtès]

Federico Beffa <address@hidden> skribis:

> On Thu, Jan 8, 2015 at 9:26 PM, Ludovic Courtès <address@hidden> wrote:
>> Federico Beffa <address@hidden> skribis:
>>
>>> On Thu, Jan 8, 2015 at 1:39 PM, 宋文武 <address@hidden> wrote:
>>
>> [...]
>>
>>>> And I don't think the sounds, themes, cursors, wallpapers and icons are
>>>> hard depends of a application, they are for all applications.
>>>> Why not set XDG_DATA_DIRS to /run/current-system/profile/share and
>>>> $HOME/.guix-profile/share in /etc/profile? (at gnu/system.scm)
>>>> So, install a theme package will work for all applications.
>>>>
>>>> WTDY?
>>>
>>> As said above, my proposal will make sure that the relevant theming
>>> data is found and used directly from the store.
>>
>> To summarize, I think the solution you propose would have the advantage
>> of working out-of-the-box, even when Guix is used on another distro, and
>> the disadvantage to be inflexible (the set of themes, icons, etc. used
>> by an application will be fixed at build time, IIUC.)
>>
>> What 宋文武 proposes would have the advantage of being more flexible
>> (users can install the themes they prefer), but would work only on
>> “Guixotic”, and not out-of-the-box (users will have to remember to
>> install one sound theme, icon set, etc.)
>>
>> Does that make sense?
>
> I do not see the two methods as alternatives, but as complementary and
> co-working: my proposal makes sure that a package works out of the box
> by *prefixing* XDG_DATA_DIRS (and not replacing it). So a user is
> still able to add themes in his own profile.
>
> Or, do you see any problem? 

Oh no, you're right.  Sorry for the confusion.

> Or, would you prefer to append instead to prefix?

Yes, rather append, otherwise users would be unable to change it, no?

Do you need anything else for the review?

Thanks!

Ludo’.