Re: [PATCH 1/4] guix: build/glib-or-gtk-build-system: Add support for GIO and XDG theming.

[Ludovic Courtès]

Federico Beffa <address@hidden> skribis:

> On Sat, Jan 10, 2015 at 10:08 PM, Ludovic Courtès <address@hidden> wrote:
>> Yes, rather append, otherwise users would be unable to change it, no?
>
> My reasoning for choosing to prefix is as follows: we want the
> application to find the data version that it was compiled with (GLib
> schemas, ...) to avoid clashing with incompatible updates.  However,
> we want to be able to extend the search path to add optional data not
> available at compile time. If a user really wants to override one of
> the compile time data path, he still has the possibility to use
> XDG_DATA_HOME.
>
> WDYT?

Ah yes, that makes sense.  I guess for schemas we really want the
application to use those produced at build time, whereas for things like
icons, it would be OK to use anything (I suppose.)

But XDG_DATA_DIRS is coarse-grain, so prefixing seems safer, indeed.

>> Do you need anything else for the review?
>
> If we agree on the above, then I'm just waiting for an "OK to push" :-)

Then OK to push.  :-)

Thanks for explaining!

Ludo’.