Re: gnu: Add CLISP.

[Eric Bavier]

On Fri, 13 Feb 2015 00:48:05 +0100
address@hidden (Taylan Ulrich Bayırlı/Kammer) wrote:

> From 6201470b3e6c2410be7f38d8cc1cc99c3b13f0da Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <address@hidden>
> Date: Thu, 12 Feb 2015 22:19:52 +0100
> Subject: [PATCH] gnu: Add CLISP.
> 
> * gnu/packages/lisp.scm (clisp): New variable.
[...]
> +    (arguments
> +     '(#:phases
> +       (alist-cons-after
> +        'unpack 'post-unpack

Could you use a more descriptive phase name?  E.g. "patch-sh-and-pwd"?

> +        (alist-cons-before
> +         'build 'pre-build

Ditto.  Several other packages use "chdir" or "chdir-to-source"

> +       ;; Parallel builds seem to fail.
> +       #:parallel-build? #f))

If you know more specifically why parallel builds fail, could you
comment on that?  Race conditions, or not using $(MAKE), etc?

> +    (home-page "http://www.clisp.org/";)
> +    (synopsis "A feature-rich Common Lisp implementation")

Do not begin with "A"; `guix lint` will complain about that.  Perhaps
just "Common Lisp implementation".

> +    (description "GNU CLISP is an implementation of ANSI Common
> Lisp, with +many extensions.  It includes an interpreter, compiler,
             ^
"+many" -> "many"

> debugger, CLOS, MOP, +an FFI, i18n, POSIX and Perl regular
                       ^
"+an" -> "an"

> expressions, a socket interface, fast +bignums, arbitrary precision
                                        ^
"+bignums" -> "bignums"

> floats, and more.  An X11 interface is available +through CLX, Garnet
                                                   ^
"+through" -> "through"

> and CLUE/CLIO.  Command line editing is provided by +readline.")
                                                      ^
"+readline" -> "readline"

Copy and paste + wrapping errors? ;)

> +    ;; Website says gpl2+, COPYRIGHT file says gpl2; actual source
> files have
> +    ;; a lot of gpl3+.  (Also some parts are under non-copyleft
> licenses, such
> +    ;; as CLX by Texas Instruments.)
> +    (license (list license:gpl2 license:gpl2+ license:gpl3+))))

I think in this case the gpl3+ might "win out", but I'll let others
comment on that.

Thanks!
`~Eric