Re: [PATCH] gnu: Add gnugo.

[Alex Kost]

Hello, I didn't try the patch, but I have a couple of notes.

David Hashe (2015-02-19 16:57 +0300) wrote:

> ---
>  gnu-system.am          |  1 +
>  gnu/packages/gnugo.scm | 44 ++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 45 insertions(+)
>  create mode 100644 gnu/packages/gnugo.scm
>
> diff --git a/gnu-system.am b/gnu-system.am
> index eeadd8f..723a00c 100644
> --- a/gnu-system.am
> +++ b/gnu-system.am
> @@ -122,6 +122,7 @@ GNU_SYSTEM_MODULES =                              \
>    gnu/packages/global.scm                    \
>    gnu/packages/gnome.scm                     \
>    gnu/packages/gnunet.scm                    \
> +  gnu/packages/gnugo.scm                     \

Alphabetically it should be above gnunet.scm.

[...]

> +    (build-system gnu-build-system)
> +    (inputs `(("readline" , readline)
> +              ("texinfo", texinfo)))

Should be: “("readline" ,readline)” and “("texinfo" ,texinfo)”
(without spaces after the commas)

> +    (synopsis "Go game")
> +    (description "GNU Go is a program that plays the game of Go, in which 
> players place stones on a grid to form territory or capture other stones.  
> While it can be played directly from the terminal, rendered in ASCII 
> characters, it is also possible to play GNU Go with 3rd party graphical 
> interfaces or even in Emacs.  It supports the standard game storage format 
> (SGF, Smart Game Format) and inter-process communication format (GMP, Go 
> Modem Protocol)")

Please, wrap the description to 72-78 chars (some people even make 80
chars per line) and add a period at the end of the final sentence.  Also
you may test it with "guix lint gnugo".

> +    (home-page "http://www.gnu.org/software/gnugo/";)
> +    (license gpl3+)))

-- 
Alex