Re: [PATCH] gnu: Add gnugo.

[Mark H Weaver]

Hi!

David Hashe <address@hidden> writes:

> ---
>  gnu-system.am          |  1 +
>  gnu/packages/gnugo.scm | 44 ++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 45 insertions(+)
>  create mode 100644 gnu/packages/gnugo.scm

I agree with the feedback from Alex Kost and Andreas Enge,
and will only add two more comments:

* It needs a proper commit message.  Assuming that it ends up in
  games.scm, the commit message would be:

--8<---------------cut here---------------start------------->8---
gnu: Add gnugo.

* gnu/packages/games.scm (gnugo): New variable.
--8<---------------cut here---------------end--------------->8---

* Regarding the 'texinfo' input: I'm not sure if it's needed or not, but
  if it turns out to be needed, it certainly belongs in 'native-inputs',
  not 'inputs'.  The difference is only important when cross-compiling.

Thank you, and welcome to our community :)

     Mark