Re: [PATCH] gnu: Add quvi.

[Andreas Enge]

On Wed, Mar 04, 2015 at 11:00:56PM +0100, Taylan Ulrich Bayırlı/Kammer wrote:
> This actually adds three packages but they're closely tied together.

Still, could you commit them as three separate packages?

> +    (description "This package contains the support scripts called upon by
> +libquvi to parse media stream properties.")

"called" instead of "called upon"?

> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://sourceforge/quvi/libquvi-" version ".tar.xz"))
> +       (sha256
> +        (base32 "00x9gbmzc5cns0gnfag0hsphcr3cb33vbbb9s7ppvvd6bxz2z1mm"))))

Your indentation (here and further down) is not quite consistens, sometimes
it it one, sometimes two spaces.

> +          (string-append "liblua_CFLAGS=-I" lua "/include")
> +          (string-append "liblua_LIBS=-L" lua "/libs -llua")))))

These are two flags and should be two entries in the list.

Apart from that, they look good to push.

Andreas