Re: [PATCH] gnu: Add quvi.

[Mark H Weaver]

Andreas Enge <address@hidden> writes:

> On Wed, Mar 04, 2015 at 11:00:56PM +0100, Taylan Ulrich Bayırlı/Kammer wrote:
>> This actually adds three packages but they're closely tied together.
>
> Still, could you commit them as three separate packages?

I'm familiar with these packages, and I tend to agree that they are so
closely tied that it's reasonable to commit them together.

>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "mirror://sourceforge/quvi/libquvi-" version ".tar.xz"))
>> +       (sha256
>> +        (base32 "00x9gbmzc5cns0gnfag0hsphcr3cb33vbbb9s7ppvvd6bxz2z1mm"))))
>
> Your indentation (here and further down) is not quite consistens, sometimes
> it it one, sometimes two spaces.

He's using the auto-indenter of Emacs Scheme Mode, which faithfully
follows the rules in our .dir-locals.el file.

>> +          (string-append "liblua_CFLAGS=-I" lua "/include")
>> +          (string-append "liblua_LIBS=-L" lua "/libs -llua")))))
>
> These are two flags and should be two entries in the list.

What Taylan wrote above looks right to me.  The -L[...] and -llua are
two flags, but the variable setting "liblua_LIBS=-L[...]/libs -llua"
needs to be one argument to configure.

     Thanks,
       Mark