Re: [PATCH] gnu: Add gnash.

[Ludovic Courtès]

Tomáš Čech <address@hidden> skribis:

> * gnu/packages/gnash.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add the file.

[...]

> +(define-module (gnu packages gnash)

Maybe we could call it ‘flash’ since there may be other tools going
there (players or things like libswf)?

> +  #:use-module (guix build-system gnu)
> +  )

Move the paren to the previous line.

> +       ;; release is too old to be built correctly against ffmpeg, libjpeg 
> and
> +       ;; more, lets go with head containing all required fixes already
> +       (method git-fetch)

We have ffmpeg-2.2 and libjpeg-8 already available.  Would that allow us
to build from the release tarball?

If yes, we should probably do that, plus the CVE-2012-1175 patch at
<http://git.savannah.gnu.org/cgit/gnash.git/patch/?id=bb4dc77eecb6ed1b967e3ecbce3dac6c5e6f1527>
(don’t know if there are others.)

> +     ;; gstreamer 0.10 is required, but not available, gstreamer-1.0 not

gstreamer-0.10 is available from (gnu packages gstreamer).

> +    (synopsis "GNU Flash movie player")
> +    (description "GNU Gnash is the GNU Flash movie player — Flash is an
> +animation file format pioneered by Macromedia which continues to be 
> supported by
> +their successor company, Adobe.  Flash has been extended to include audio and
> +video content, and programs written in ActionScript, an ECMAScript-compatible
> +language.  Gnash is based on GameSWF, and supports most SWF v7 features and
> +some SWF v8 and v9.  SWF v10 is not supported by GNU Gnash.")

Please use those suggested by ‘guix lint’.

> +    (license l:gpl3)))

l:gpl3+

Could you send an updated patch?


In the Nixpkgs recipe I had added this hack:

+    # Provide a default font.
+    sed -i "configure" \
+        -e 
's|/usr/share/fonts/truetype/freefont/|${freefont_ttf}/share/fonts/truetype/|g'

Any idea if this is still needed?  IOW, does gtk-gnash manage to display
text at all without it?

Thank you!

Ludo’.