guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add gnash.


From: Tomáš Čech
Subject: Re: [PATCH] gnu: Add gnash.
Date: Thu, 19 Mar 2015 22:22:16 +0100
User-agent: Mutt/1.5.23 (2014-03-12)

On Thu, Mar 19, 2015 at 05:17:10PM +0100, Ludovic Courtès wrote:
Tomáš Čech <address@hidden> skribis:

* gnu/packages/gnash.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add the file.

[...]

+(define-module (gnu packages gnash)

Maybe we could call it ‘flash’ since there may be other tools going
there (players or things like libswf)?

Yes, that was my working name - when I got circular deps in web
module, I moved it to separate file. `flash' is good name - I'm
already working on lightspark which will go there as well...

+  #:use-module (guix build-system gnu)
+  )

Move the paren to the previous line.

OK

+       ;; release is too old to be built correctly against ffmpeg, libjpeg and
+       ;; more, lets go with head containing all required fixes already
+       (method git-fetch)

We have ffmpeg-2.2 and libjpeg-8 already available.  Would that allow us
to build from the release tarball?

The problem is incompatibility between the release (2 years old) and
the versions we have in Guix (ffmpeg, libjpeg, boost, automake, gcc
and mabe more). I originally started with the release tarball and took
bunch of patches which fixed ffmpeg changes and libjpeg changes but it
was just too many so I gave up.


If yes, we should probably do that, plus the CVE-2012-1175 patch at
<http://git.savannah.gnu.org/cgit/gnash.git/patch/?id=bb4dc77eecb6ed1b967e3ecbce3dac6c5e6f1527>
(don’t know if there are others.)

+     ;; gstreamer 0.10 is required, but not available, gstreamer-1.0 not

gstreamer-0.10 is available from (gnu packages gstreamer).

In that case `guix package -s gstreamer' didn't show that to me.

Btw. I run this command several times and it's showing versions
randomly (in following case gst-plugins-base has different version):

guix package -s gstreamer | recsel -p name,version

---------%<----------------------------%<--------------------
$ guix package -s gstreamer | recsel -p name,version
name: gst-plugins-base
version: 0.10.36

name: gst-plugins-good
version: 1.4.5

name: gstreamer
version: 1.4.5

name: libcanberra
version: 0.30

$ guix package -s gstreamer | recsel -p name,version
name: gst-plugins-base
version: 1.4.5

name: gst-plugins-good
version: 1.4.5

name: gstreamer
version: 1.4.5

name: libcanberra
version: 0.30
--------->%---------------------------->%--------------------

Grep found it reliably.

+    (synopsis "GNU Flash movie player")
+    (description "GNU Gnash is the GNU Flash movie player — Flash is an
+animation file format pioneered by Macromedia which continues to be supported 
by
+their successor company, Adobe.  Flash has been extended to include audio and
+video content, and programs written in ActionScript, an ECMAScript-compatible
+language.  Gnash is based on GameSWF, and supports most SWF v7 features and
+some SWF v8 and v9.  SWF v10 is not supported by GNU Gnash.")

Please use those suggested by ‘guix lint’.

Where did that text come from!? Will do.


+    (license l:gpl3)))

l:gpl3+

Thanks.


Could you send an updated patch?


In the Nixpkgs recipe I had added this hack:

+    # Provide a default font.
+    sed -i "configure" \
+        -e 
's|/usr/share/fonts/truetype/freefont/|${freefont_ttf}/share/fonts/truetype/|g'

Any idea if this is still needed?  IOW, does gtk-gnash manage to display
text at all without it?

It's hard to find flash old enough, showing text and with sources to
confirm it's text. I think that this can be used for verification:

http://technoargia.free.fr/swftools/examples/button3/button3.html

And yes, works for me.

Thanks for review.

S_W

Attachment: pgphd0zVRQgW7.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]