Re: [PATCH v2] gnu: Add taskwarrior.

[Ludovic Courtès]

Tomáš Čech <address@hidden> skribis:

> From: Tomáš Čech <address@hidden>
>
> * gnu/packages/task.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

To complement Cyril’s review:

> +(define-module (gnu packages task)

‘task-management’, as you proposed, would be better.  Would there be
other packages in there?

> +    (description
> +     "Taskwarrior is mature command line task manager following Getting 
> Things

Missing articles: “a mature”, “following the Getting Things Done ... method”.

> +Done time management method.  It supports network synchronization, filtering
> +and quering data, exposing task data in multiple formats to other tools which
> +allowed to create healthy ecosystem of tools using taskwarrior.")

Please remove “which allowed ...” (marketing stuff.)

> +    ;; Taskwarrior is licensed under MIT license, which is identical to
> +    ;; Expat License

Please remove this comment.  It’s just that “MIT license” is an
ambiguous name for the Expat license.

Could you send an updated patch?

Thanks!

Ludo’.