Re: [PATCH v2] gnu: Add taskwarrior.

[Tomáš Čech]

On Thu, Mar 26, 2015 at 06:03:45PM +0100, Ludovic Courtès wrote:
> Tomáš Čech <address@hidden> skribis:
>
> > From: Tomáš Čech <address@hidden>
> >
> > * gnu/packages/task.scm: New file.
> > * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
>
> To complement Cyril’s review:
>
> > +(define-module (gnu packages task)
>
> ‘task-management’, as you proposed, would be better.  Would there be
> other packages in there?

I don't plan more packages ATM.

> > +    (description
> > +     "Taskwarrior is mature command line task manager following Getting Things
>
> Missing articles: “a mature”, “following the Getting Things Done ... method”.

Fixed.

> > +Done time management method.  It supports network synchronization, filtering
> > +and quering data, exposing task data in multiple formats to other tools which
> > +allowed to create healthy ecosystem of tools using taskwarrior.")
>
> Please remove “which allowed ...” (marketing stuff.)

Fixed. (it's my opinion, not marketing :)
> > +    ;; Taskwarrior is licensed under MIT license, which is identical to
> > +    ;; Expat License
>
> Please remove this comment.  It’s just that “MIT license” is an
> ambiguous name for the Expat license.

I'm really not friend of this. But I asked authors and they don't mind
call their license Expat in spite of their choice so I changed that as
you wish.

> Could you send an updated patch?

Sent.

Tomas

pgpgYfAT56W1Q.pgp
Description: PGP signature