Re: [PATCH 0/2] Services configuration syntaxes patches.

[Andy Wingo]

Hi Clément,

On Tue 28 Feb 2017 23:50, Clément Lassieur <address@hidden> writes:

> There was a bug in the dovecot service introduced by a refactoring of syntaxes
> functions.  I don't think those functions should be put in a common file,
> because syntaxes are often specific to services, as I explained in one of the
> commit messages.
>
> Therefore I did two commits.  The first fixes the bug.  The other removes
> functions that should not be abstracted from configuration.scm, and put them
> back into their specific services.
>
> The second commit should not have any actual effect, but I checked that
> services depending on configuration.scm were still working and:
>   - Dovecot works (because of the first commit).
>   - Prosody works (no changes).
>   - Cups works.
>   - I don't know how to test Kerberos, but its configuration file didn't move.
>   - OpenVPN does not build when put in config.scm, because of a tls issue, so
>     I could not check (but I didn't need to modify it).
>
> WDYT?

Great patches; will apply when I get to my other machine :)

Andy