|
From: | Caleb Ristvedt |
Subject: | Re: [PATCH] Prototype register-path |
Date: | Mon, 05 Jun 2017 03:38:19 -0500 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
I think I may have accidentally left some stuff out of that patch due to being new to "git format-patch" - I did several fixups which I'm not sure were included. Anyway, I've changed it so that register-path now honors the NIX_* environment variables that are relevant to it, which means it now passes "make check TESTS=tests/store.scm". Still quite a bit more to do, mainly resetting timestamps/permissions and deduplication. I'm especially pleased with how the interaction between environment variables, parameters, and defaults is now a straightforward priority list using a cond. Said interactions were spread out across the C++ codebase using global variables (well, one global variable) and lots of state-changing, so I feel pretty good about getting that in one place. A question about protocol, though - should followup patches like this be replies or new top-level posts? And how often should I send them? Again, comments welcome.
0001-Implement-prototype-register-path-in-scheme.patch
Description: Text Data
0002-fixup-Implement-prototype-register-path-in-scheme.patch
Description: Text Data
0003-fixup-Implement-prototype-register-path-in-scheme.patch
Description: Text Data
0004-fixup-Implement-prototype-register-path-in-scheme.patch
Description: Text Data
0005-fixup-Implement-prototype-register-path-in-scheme.patch
Description: Text Data
0006-Honor-environment-variables-in-guix-register.patch
Description: Text Data
0007-fixup-Honor-environment-variables-in-guix-register.patch
Description: Text Data
[Prev in Thread] | Current Thread | [Next in Thread] |