guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#74962] [PATCH 3/3] etc/guix-install.sh: Fix quoting and other issue


From: Ludovic Courtès
Subject: [bug#74962] [PATCH 3/3] etc/guix-install.sh: Fix quoting and other issues.
Date: Thu, 26 Dec 2024 11:55:37 +0100
User-agent: Gnus/5.13 (Gnus v5.13)

Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> This change fixes most issues reported by the 'shellcheck' command.
>
> * etc/guix-install.sh (add_init_sys_require): Use -n instead of ! -z.
> (sys_create_build_user): Quote variable expansion.
> (sys_delete_build_user): Likewise.
> (sys_create_shell_completion): Likewise.
> (sys_delete_user_profiles): Likewise.
> (main): Replace $@ with $* inside string.
>
> Change-Id: Ia88509b461b3844f2dd5abf9fb21a5b2bbb8a1e1

LGTM.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]