[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#74962] [PATCH v3 4/5] etc/guix-install.sh: Remove 'which' commands
From: |
Ludovic Courtès |
Subject: |
[bug#74962] [PATCH v3 4/5] etc/guix-install.sh: Remove 'which' commands from requirements. |
Date: |
Sat, 28 Dec 2024 17:53:44 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Simon Josefsson <simon@josefsson.org> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>>
>>> * etc/guix-install.sh (REQUIRE): Remove "which". Add "nologin".
>>> (sys_create_build_user): Use 'type' instead of 'which'.
>>>
>>> Fixes: <https://issues.guix.gnu.org/74952>
>>> Reported-by: Simon Josefsson <simon@josefsson.org>
>>> Change-Id: I0675716bab3fc22d3289ee7af2cb0ab33a1cee71
>>
>> LGTM.
>
> Using 'type -P' is not POSIX and neither /bin/dash nor /bin/gash
> supports it. It seems like a GNU bash extension. Is that okay?
Oh, not great. From what you write, I’m not sure what to conclude;
just skip this patch and be done with it?
Thanks!
Ludo’.
- [bug#74962] [PATCH 2/3] etc/guix-install.sh: Explicit shebang to use /usr/bin/env., (continued)
[bug#74962] [PATCH v3 5/5] etc/guix-install.sh: Sort requirements., Maxim Cournoyer, 2024/12/19
[bug#74962] [PATCH] etc/guix-install.sh: Explicit shebang to use /usr/bin/env., Ludovic Courtès, 2024/12/26