Re: Support for guile-config 0.5

[Ricardo Wurmus]

Hi,

thank you for the patch.

> The `optional` in the configuration specification has been removed and
> `argument` and `switch` are now interpreted as mandatory when `default`
> is `empty`.

The patch looks wrong to me, but maybe I’m just misunderstanding things.

> diff --git a/gwl/config.scm.in b/gwl/config.scm.in
> index 9ab58e5..f789998 100644
> --- a/gwl/config.scm.in
> +++ b/gwl/config.scm.in
> @@ -65,7 +65,6 @@ workflow.")
>         (list
>          (argument
>           (name 'file)
> -         (optional? #false)
>           (test file-exists?)
>           (handler identity)
>           (example "/path/to/my-workflow.w"))))
> @@ -95,12 +94,14 @@ workflow.")
>           (character #\i)
>           (synopsis "Specify workflow input NAME, optionally mapped to FILE")
>           (example "NAME[=FILE]")
> +         (default "")
>           (test string?))

Okay.

>          (switch
>           (name 'output)
>           (character #\o)
>           (synopsis "Set LOCATION as output for a workflow")
> -         (example "LOCATION"))
> +         (example "LOCATION")
> +         (default ""))

This makes the “output” switch mandatory, but it’s optional.

>          (switch
>           (name 'engine)
>           (character #\e)
> @@ -147,7 +148,6 @@ format) of the specified workflow.")
>         (list
>          (argument
>           (name 'file)
> -         (optional? #false)
>           (test file-exists?)
>           (handler identity)
>           (example "/path/to/my-workflow.w")))))

And this just makes the file argument optional, but it’s not.

-- 
Ricardo