Re: Support for guile-config 0.5

[Taiju HIGASHI]

Hi Ricardo,

Thank you for reviewing.

I'm not confident in them, but I will tell you my thought.

>>          (switch
>>           (name 'output)
>>           (character #\o)
>>           (synopsis "Set LOCATION as output for a workflow")
>> -         (example "LOCATION"))
>> +         (example "LOCATION")
>> +         (default ""))
>
> This makes the “output” switch mandatory, but it’s optional.

The (default (empty)) and the (default "") are different things.
The (default (empty)) is the default value of the switch record default field.
If I don't add that line, that switch will make evaluated as mandatory
because the default field is (empty). [1]

>>          (switch
>>           (name 'engine)
>>           (character #\e)
>> @@ -147,7 +148,6 @@ format) of the specified workflow.")
>>         (list
>>          (argument
>>           (name 'file)
>> -         (optional? #false)
>>           (test file-exists?)
>>           (handler identity)
>>           (example "/path/to/my-workflow.w")))))
>
> And this just makes the file argument optional, but it’s not.

It is not to change the meaning.
The optional field of the argument record has been removed, so if I do
not delete it, thus it will cause an error.

Since the default value of the default field of the argument record is
(empty),  If I want to mandatory an argument record, In case I just
delete the (optional? #f) line. [2]

Sorry if I am wrong.

[1]:
https://gitlab.com/a-sassmannshausen/guile-config/-/blob/6a00702d044663fef6d6d619f4aeb75417e1b10b/config/api.scm#L167
[2]:
https://gitlab.com/a-sassmannshausen/guile-config/-/commit/9c1b1627dee927839049168a1dfc2500955c83a6#7643f2674b06b682eb8c0695dfc8e1c252099b2f

Cheers,
--
taiju