libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ac_ (Was: Remove -fPIC -DPIC under DJGPP)


From: Akim Demaille
Subject: Re: ac_ (Was: Remove -fPIC -DPIC under DJGPP)
Date: 15 Dec 2000 11:44:31 +0100
User-agent: Gnus/5.0807 (Gnus v5.8.7) XEmacs/21.1 (Channel Islands)

>>>>> "Alexandre" == Alexandre Oliva <address@hidden> writes:

Akim> Aaaaaah!  Libtool uses the ac_ name space???  That's quite risky...
Alexandre> Indeed.  Feel free to clean it up (I really mean it :-)

Here is my proposal for the regular branch, I'm now looking into mlt.

There are things I don't understand too well: why is there frequently
the comment ``should be a separate macro'', and indeed why aren't
they?  It looks like a simple operation, so I must miss something.

Also, I find that

| # AC_PATH_TOOL_PREFIX - find a file program which can recognise shared library
| AC_DEFUN([AC_PATH_TOOL_PREFIX],
| [AC_MSG_CHECKING([for $1])
| AC_CACHE_VAL(lt_cv_path_MAGIC_CMD,
| [case "$MAGIC_CMD" in
|   /*)
|   lt_cv_path_MAGIC_CMD="$MAGIC_CMD" # Let the user override the test with a 
path.
|   ;;
|   ?:/*)
|   lt_cv_path_MAGIC_CMD="$MAGIC_CMD" # Let the user override the test with a 
dos path.
|   ;;

is a weird name and documentation for what this macro seems to be
actually doing.

There is something I don't understand well: is it normal that make
check fails, but make check VERBOSE=yes works fine?

This patch removes all the trailing spaces, be sure to keep spaces.

I have no more failures than without this patch.

Attachment: diffs
Description: Text Data

Akim

reply via email to

[Prev in Thread] Current Thread [Next in Thread]