Re: libtool.m4-mingw-lib-searchdirs-01.patch

[Guido Draheim]

Robert Boehne wrote:
>
> OK, I'm checking this in.
> 
> Robert
> 

please no! 

 I noticed later that it is a better idea to just use $PATH_SEPARATOR
 in the last sed-part and make sure that this very variable does exist.
 Currently it is implicitly done through initialisation order, but
 one could even attach an AC_REQUIRE at the top of this very DEFUN.
 I talked about it later on, and I did think that it would be done as
 last communicated - see the last mail from Gary (!!!!!) that does also
 contain `sed -e /-print-search-dirs/s,/;/,/$PATH_SEPARATOR/,` as the
 proposed patching scheme - there's no more needed. The rest of what
 there is in patch-01 happens to be just a bit overcautious, and 
 I don't think anymore that it is actually needed as such. The simple
 patch has shown to be sufficient for quite a while now.

 What makes me wonder - Gary has already done the simple patch!!!! 
 - it is in version 1.202 of libtool.m4 - and the version 1.208 does
 now contain a doubled patch about sys_lib searchdirs mingw fixup.
 
 Ouch, Guido

 P.S. Here's that patch that I did send named as patch-02 - apart
 from what that sed-line above would do, it adds that AC_REQUIRE.
 May be I'll better make up another one if anyone here feels that
 adding AC_REQUIRE is a good thing. But as I see it - may be it
 is a good thing to quickly remove that patch-01 that has gone on
 top of Gary's 1.202 patching on the same topic. Sorry for all
 the inconveniences....


> [...]
> > +    if test "_$PATH_SEPARATOR" = "_:" ; then
> > +       sys_lib_search_path_spec=`echo $sys_lib_search_path_spec | sed -e 
> > 's/:/ /g'`
> > +    elif test "_$PATH_SEPARATOR" = "_;" ; then
> > +       sys_lib_search_path_spec=`echo $sys_lib_search_path_spec | sed -e 
> > 's/;/ /g'`
> > +    else
> > +        if test "x$sys_lib_search_path_spec" != `echo 
> > x$sys_lib_search_path_spec | sed -e 's/;/ /'` ; then
> > +           AC_MSG_ERROR(PATH_SEPARATOR not set, but $CC -print-search-dirs 
> > contains semicolons)
> > +        elif test "x$sys_lib_search_path_spec" != `echo 
> > x$sys_lib_search_path_spec | sed -e 's/:/ /'` ; then
> > +           AC_MSG_ERROR(PATH_SEPARATOR not set, but $CC -print-search-dirs 
> > contains colons)
> > +       fi
> > +    fi
> >      ;;
> >    yes,pw32*)
> >      library_names_spec='`echo ${libname} | sed -e 's/^lib/pw/'``echo 
> > ${release} | sed -e 's/[.]/-/g'`${versuffix}.dll'
>

--- libtool.m4.20010725 Wed Jul 25 12:20:26 2001
+++ libtool.m4  Wed Jul 25 12:23:36 2001
@@ -953,7 +953,8 @@
 # -----------------------------
 # PORTME Fill in your ld.so characteristics
 AC_DEFUN([AC_LIBTOOL_SYS_DYNAMIC_LINKER],
-[AC_MSG_CHECKING([dynamic linker characteristics])
+[AC_REQUIRE([_LT_AC_LIBTOOL_SYS_PATH_SEPARATOR])dnl
+AC_MSG_CHECKING([dynamic linker characteristics])
 library_names_spec=
 libname_spec='lib$name'
 soname_spec=
@@ -1071,7 +1072,7 @@
     ;;
   yes,mingw*)
     library_names_spec='${libname}`echo ${release} | [sed -e 
's/[.]/-/g']`${versuffix}.dll'
-    sys_lib_search_path_spec=`$CC -print-search-dirs | grep "^libraries:" | 
sed -e "s/^libraries://" -e "s/;/ /g"`
+    sys_lib_search_path_spec=`$CC -print-search-dirs | grep "^libraries:" | 
sed -e "s/^libraries://" -e "s/$PATH_SEPARATOR/ /g"`
     ;;
   yes,pw32*)
     library_names_spec='`echo ${libname} | sed -e 's/^lib/pw/'``echo 
${release} | sed -e 's/[.]/-/g'`${versuffix}.dll'