Re: rewrite try_dlopen (1)

[Gary V. Vaughan]

Hi Ralf,

Ralf Wildenhues wrote:
> This is the first step at rewriting try_dlopen:
> It moves the code which parses the .la file out of
> try_dlopen in to a separate function.

Great!  This work is *so* overdue it's not funny.  Thanks for
tackling it :-)

Might I suggest having a struct to hold the parsed la file, both
to reduce the number of pass-by-reference parameters, and to make
the function interface stable in the face of a changing .la spec.

> I have deliberately not changed the function code
> except for necessary pointer changes, so that the
> change is easier to check.  I find the parsing code
> ugly, but a rewrite should come later.  Also, I
> think try_dlopen shall shrink further.

All good!  If you feel like making notes on a formal specification
for .la files for a future revision, that would be even cooler ;-)

> 2004-10-03  Ralf Wildenhues <address@hidden>
>
>         * libltdl/ltdl.c (try_dlopen): Move .la file parsing
>         part.. (parse_dotla_file): ..here.  Adjust.

Now we have branched for 2.0, please commit this on HEAD. :-)

Cheers,
        Gary.
--
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

signature.asc
Description: OpenPGP digital signature