Re: 10-csw-cygwin-install-strip.patch

[Ralf Wildenhues]

* Albert Chin wrote on Sat, Oct 30, 2004 at 04:15:46AM CEST:
> On Thu, Oct 28, 2004 at 01:10:05PM -0400, Charles Wilson wrote:
> > Index: config/ltmain.m4sh
> > ===================================================================
> > RCS file: /cvsroot/libtool/libtool/config/ltmain.m4sh,v
> > retrieving revision 1.1.2.12
> > diff -u -r1.1.2.12 ltmain.m4sh
> > --- config/ltmain.m4sh      20 Oct 2004 08:41:34 -0000      1.1.2.12
> > +++ config/ltmain.m4sh      28 Oct 2004 17:03:37 -0000
> > @@ -1827,7 +1827,16 @@
> >       # Install the shared library and build the symlinks.
> >       $show "$install_prog $dir/$srcname $destdir/$realname"
> >       $run eval "$install_prog $dir/$srcname $destdir/$realname" || exit $?
> > -     if test -n "$stripme" && test -n "$striplib"; then
> > +     tstripme="$stripme"
> > +     case $host in
> > +     *-*-cygwin* | *-*-mingw* | *-*-pw32* | *-*-os2*)
> > +       case $realname in
> > +       *.dll.a)
> > +         tstripme=""
> > +         ;;
> > +       esac
> > +     esac
> > +     if test -n "$tstripme" && test -n "$striplib"; then
> >         $show "$striplib $destdir/$realname"
> >         $run eval "$striplib $destdir/$realname" || exit $?
> >       fi
> 
> Why not just:
>         case $host in
>         *-*-cygwin* | *-*-mingw* | *-*-pw32* | *-*-os2*)
>           case $realname in
>           *.dll.a)
>             ;;
>           *)
>             if test -n "$stripme" && test -n "$striplib"; then
>               $show "$striplib $destdir/$realname"
>               $run eval "$striplib $destdir/$realname" || exit $?
>             fi
>             ;;
>           esac
>         esac

Maybe because then you don't strip on other systems?
Am I missing something obvious?

Regards,
Ralf