Re: 10-csw-cygwin-install-strip.patch

[Peter O'Gorman]

Peter O'Gorman wrote:

> Albert Chin wrote:
>
>
> > Huh? Both don't strip on win32 but do strip on all other platforms.
>
> But your version does not strip anything on win32, the original version 
> still stripped files on win32 if the extension was not .dll.a.

Never mind, I need to read things more carefully, Ralf was correct.

-         if test -n "$stripme" && test -n "$striplib"; then
> +    tstripme="$stripme"
> +    case $host in
> +    *-*-cygwin* | *-*-mingw* | *-*-pw32* | *-*-os2*)
> +      case $realname in
> +      *.dll.a)
> +        tstripme=""
> +        ;;
> +      esac
> +    esac
> +    if test -n "$tstripme" && test -n "$striplib"; then

Okay, so on non-win platforms nothing changes, on win32 platforms stripping 
is restricted to files not ending in .dll.a

Your patch:
          case $host in
          *-*-cygwin* | *-*-mingw* | *-*-pw32* | *-*-os2*)
            case $realname in
            *.dll.a)
              ;;
            *)
              if test -n "$stripme" && test -n "$striplib"; then
                $show "$striplib $destdir/$realname"
                $run eval "$striplib $destdir/$realname" || exit $?
              fi
              ;;
            esac
          esac
If simply inserted above the current:
if test -n "$stripme" && test -n "$striplib"; then
would do no good, as it would not stop libraries from being stripped on 
win32 (the second instance of the strip would get it) If it replaced the 
current "if test -n "$stripme" && test -n "$striplib"; then" then as Ralf 
suggests, it would stop all stripping on non-win32 platforms.

YOu could probably change it to:

case $host,$realname in
*-*-cygwin* | *-*-mingw* | *-*-pw32* | *-*-os2*,*.dll.a) ;;
*,*)
if test -n "$stripme" && test -n "$striplib"; then
  $show "$striplib $destdir/$realname"
  $run eval "$striplib $destdir/$realname" || exit $?
fi
;;
esac

or somehting just as confusing, but I see nothing wrong with the original patch.

Peter
--
Peter O'Gorman - http://www.pogma.com