libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Pass --quiet when $MAKEFLAGS contains `s'


From: Ben Elliston
Subject: Pass --quiet when $MAKEFLAGS contains `s'
Date: Wed, 12 Jan 2005 14:57:01 +1100
User-agent: Mutt/1.2.5.1i

Hi folks,

Library projects that use libtool (such as libjava) are noisy, even
when `make -s' is used.  Although make(1) silences its command output,
libtool does not and you end up with as much command output as you
might expect from a Makefile that is executed without -s.  This little
patch corrects that by throwing --quiet in such circumstances.

If it's okay, please commit on my behalf.

Ben

2005-01-12  Ben Elliston  <address@hidden>

       * config/ltmain.m4sh: Set opt_silent to true if $MAKEFLAGS in the
       environment contains `s' (ie. make was invoked with -s).
       * doc/libtool.texi (Invoking libtool): Document this behaviour.

Index: config/ltmain.m4sh
===================================================================
RCS file: /cvsroot/libtool/libtool/config/ltmain.m4sh,v
retrieving revision 1.41
diff -u -p -r1.41 ltmain.m4sh
--- config/ltmain.m4sh  10 Jan 2005 15:44:13 -0000      1.41
+++ config/ltmain.m4sh  12 Jan 2005 03:28:27 -0000
@@ -117,7 +117,10 @@ o2lo="s/\\.${objext}\$/.lo/"
 
 opt_dry_run=false
 opt_duplicate_deps=false
-opt_silent=false
+case `echo "$MAKEFLAGS" | sed -e 's/\([^ ]*\).*/\1/'` in
+  *s*) opt_silent=true
+  *)   opt_silent=false
+esac
 opt_debug=:
 
 # If this variable is set in any of the actions, the command in it
Index: doc/libtool.texi
===================================================================
RCS file: /cvsroot/libtool/libtool/doc/libtool.texi,v
retrieving revision 1.187
diff -u -p -r1.187 libtool.texi
--- doc/libtool.texi    28 Dec 2004 13:13:14 -0000      1.187
+++ doc/libtool.texi    12 Jan 2005 03:28:29 -0000
@@ -1174,7 +1174,8 @@ that libtool knows it can safely.
 
 @item --quiet
 @itemx --silent
-Do not print out any progress or informational messages.
+Do not print out any progress or informational messages.  This option
+is implied when @code{MAKEFLAGS} contains @samp{s} in the environment.
 
 @item --version
 Print libtool version information and exit.

Attachment: pgpJv3cC4jVf2.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]