[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Pass --quiet when $MAKEFLAGS contains `s'
From: |
Ralf Wildenhues |
Subject: |
Re: Pass --quiet when $MAKEFLAGS contains `s' |
Date: |
Wed, 12 Jan 2005 08:04:01 +0100 |
User-agent: |
Mutt/1.5.6+20040907i |
Hi Ben,
* Ben Elliston wrote on Wed, Jan 12, 2005 at 04:57:01AM CET:
>
> Library projects that use libtool (such as libjava) are noisy, even
> when `make -s' is used. Although make(1) silences its command output,
> libtool does not and you end up with as much command output as you
> might expect from a Makefile that is executed without -s. This little
> patch corrects that by throwing --quiet in such circumstances.
>
> If it's okay, please commit on my behalf.
We've had a similar suggestion last month (thread partly in this mailing
list, partly in the libtool at gnu.org list, subject `libtool --silent
based on MAKEFLAGS?'). We've come to the conclusion that it would be
better not to abuse other tools' flags (in this case: MAKEFLAGS is for
make), but adjust Automake to call libtool with LIBTOOLFLAGS.
So you can get the same effect with
make -s LIBTOOLFLAGS=--silent
or you can even
.../configure LIBTOOLFLAGS=--silent MAKEFLAGS=-s
if your Automake is recent (for now you'll have to stick with the CVS
version, I'm afraid).
Besides, I cannot resist nitpicking:
*snip*
> --- config/ltmain.m4sh 10 Jan 2005 15:44:13 -0000 1.41
> +++ config/ltmain.m4sh 12 Jan 2005 03:28:27 -0000
> @@ -117,7 +117,10 @@ o2lo="s/\\.${objext}\$/.lo/"
>
> opt_dry_run=false
> opt_duplicate_deps=false
> -opt_silent=false
> +case `echo "$MAKEFLAGS" | sed -e 's/\([^ ]*\).*/\1/'` in
> + *s*) opt_silent=true
> + *) opt_silent=false
> +esac
*snip*
This assumes a certain `make' program -- portable reading of MAKEFLAGS
has been explored in the December thread as well.
Cheers,
Ralf