RE: libtool head stresstest.at uses $host, not $host_os

[Peter Ekberg]

Ralf Wildenhues wrote on Monday, September 12, 2005 13:51 CEST:
> Hi Peter,
> 
> * Peter Ekberg wrote on Mon, Sep 12, 2005 at 12:36:52PM CEST:
> > 
> > In stresstest.at, there's a check if the host is windows,
> > and the tests w/o -no-undefined are skipped if it is.
> > However, the test is wrong, so here's a patch.
> 
> Darn.  I guess I messed that up.
> 
> > Unfortunately, $host_os is not set, so I had to insert
> > another wildcard in the cases instead...
> 
> Well, how about just setting $host_os?  Like this:

That's even better. Please apply! (but think about nit below first)

Cheers,
Peter

> Index: tests/stresstest.at
> ===================================================================
> RCS file: /cvsroot/libtool/libtool/tests/stresstest.at,v
> retrieving revision 1.4
> diff -u -r1.4 stresstest.at
> --- tests/stresstest.at       27 Apr 2005 18:18:10 -0000      1.4
> +++ tests/stresstest.at       12 Sep 2005 11:49:51 -0000
> @@ -170,7 +170,7 @@
>  AT_CHECK([$LIBTOOL --mode=compile $CC $CFLAGS -c 
> main.c],[0],[ignore],[ignore])
>  AT_CHECK([$LIBTOOL --mode=compile $CC $CFLAGS -c dlself.c -o 
> sub3/dlself.lo],[0],[ignore],[ignore])
>  
> -case $host in
> +case $host_os in
>    cygwin* | mingw* | pw32*) undef_opts=-no-undefined ;;
>    *)                        undef_opts='"" -no-undefined' ;;
>  esac
> Index: tests/testsuite.at
> ===================================================================
> RCS file: /cvsroot/libtool/libtool/tests/testsuite.at,v
> retrieving revision 1.17
> diff -u -r1.17 testsuite.at
> --- tests/testsuite.at        23 Aug 2005 01:49:37 -0000      1.17
> +++ tests/testsuite.at        12 Sep 2005 11:49:51 -0000
> @@ -25,7 +25,7 @@
>  : ${AUTOCONF=autoconf}
>  export LIBTOOLIZE LIBTOOL ACLOCAL AUTOCONF
>  eval `$LIBTOOL --config | grep ^EGREP=`
> -eval `$LIBTOOL --config | $EGREP '(host|build)='`
> +eval `$LIBTOOL --config | $EGREP '(host|host_os|build)='`

Wouldn't the following be even better (extra '^')? Or is that
not portable?

+eval `$LIBTOOL --config | $EGREP '^(host|host_os|build)='`

>  m4_divert_pop([PREPARE_TESTS])dnl
>  
>  # LT_AT_LIBTOOLIZE([ARGS])
>