[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
FYI: libtool head stresstest.at uses $host, not $host_os
From: |
Ralf Wildenhues |
Subject: |
FYI: libtool head stresstest.at uses $host, not $host_os |
Date: |
Mon, 12 Sep 2005 14:48:43 +0200 |
User-agent: |
Mutt/1.4.1i |
Hi Peter,
* Peter Ekberg wrote on Mon, Sep 12, 2005 at 02:11:23PM CEST:
> Ralf Wildenhues wrote on Monday, September 12, 2005 13:51 CEST:
> > * Peter Ekberg wrote on Mon, Sep 12, 2005 at 12:36:52PM CEST:
> >
> > > Unfortunately, $host_os is not set, so I had to insert
> > > another wildcard in the cases instead...
> >
> > Well, how about just setting $host_os? Like this:
>
> That's even better. Please apply! (but think about nit below first)
> > +eval `$LIBTOOL --config | $EGREP '(host|host_os|build)='`
>
> Wouldn't the following be even better (extra '^')? Or is that
> not portable?
>
> +eval `$LIBTOOL --config | $EGREP '^(host|host_os|build)='`
That's perfectly fine! Applied like below to HEAD.
Cheers,
Ralf
2005-09-12 Peter Ekberg <address@hidden>,
Ralf Wildenhues <address@hidden>
* tests/testsuite.at (host_os): Pull from `libtool --config'.
* tests/stresstest.at [ cygwin, mingw, pw32 ]: Use it to fix
setting of `-no-undefined'.
Index: tests/stresstest.at
===================================================================
RCS file: /cvsroot/libtool/libtool/tests/stresstest.at,v
retrieving revision 1.4
diff -u -r1.4 stresstest.at
--- tests/stresstest.at 27 Apr 2005 18:18:10 -0000 1.4
+++ tests/stresstest.at 12 Sep 2005 12:44:58 -0000
@@ -170,7 +170,7 @@
AT_CHECK([$LIBTOOL --mode=compile $CC $CFLAGS -c main.c],[0],[ignore],[ignore])
AT_CHECK([$LIBTOOL --mode=compile $CC $CFLAGS -c dlself.c -o
sub3/dlself.lo],[0],[ignore],[ignore])
-case $host in
+case $host_os in
cygwin* | mingw* | pw32*) undef_opts=-no-undefined ;;
*) undef_opts='"" -no-undefined' ;;
esac
Index: tests/testsuite.at
===================================================================
RCS file: /cvsroot/libtool/libtool/tests/testsuite.at,v
retrieving revision 1.17
diff -u -r1.17 testsuite.at
--- tests/testsuite.at 23 Aug 2005 01:49:37 -0000 1.17
+++ tests/testsuite.at 12 Sep 2005 12:44:58 -0000
@@ -25,7 +25,7 @@
: ${AUTOCONF=autoconf}
export LIBTOOLIZE LIBTOOL ACLOCAL AUTOCONF
eval `$LIBTOOL --config | grep ^EGREP=`
-eval `$LIBTOOL --config | $EGREP '(host|build)='`
+eval `$LIBTOOL --config | $EGREP '^(host|host_os|build)='`
m4_divert_pop([PREPARE_TESTS])dnl
# LT_AT_LIBTOOLIZE([ARGS])