[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: unused variable in chase_symlinks
From: |
Eric Blake |
Subject: |
Re: unused variable in chase_symlinks |
Date: |
Mon, 23 Jul 2007 13:02:44 -0600 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.5) Gecko/20070716 Thunderbird/2.0.0.5 Mnenhy/0.7.5.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Ralf Wildenhues on 7/23/2007 11:44 AM:
> Hi Eric,
>
> Thanks for your patches. I noted a tiny nitpick in the ChangeLog entry:
>
> * Eric Blake wrote on Mon, Jul 23, 2007 at 12:44:29AM CEST:
>> * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src:
>> chase_symlinks): Avoid compiler warning.
>
> If the list of (parenthesized) functions spans more than a line, please
> close and reopen them. I corrected it like this:
>
> * libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src)
> (chase_symlinks): Avoid compiler warning.
But here, it is the chase_symlinks subsection of the
func_emit_cwrapperexe_src function, which is so huge that it provides a
bit a clarification where to look for the change. Maybe a better
rendition would be:
* libltdl/config/ltmain.m4sh (func_emit_cwrapperexe_src)
<chase_symlinks>: Avoid compiler warning.
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFGpPtU84KuGfSFAYARAs1JAKC7dhUnnV4lz2vx7fOrBOyJepj+pQCeIK/k
mukS8t6eWomv8/NBF17A40Y=
=LjNz
-----END PGP SIGNATURE-----